zeroshade commented on code in PR #1369:
URL: https://github.com/apache/iceberg-go/pull/1369#discussion_r3523576101
##########
catalog/rest/rest.go:
##########
@@ -501,19 +517,28 @@ func fromProps(props iceberg.Properties, o *options)
error {
}
}
+ // oauth2-server-uri is the portable, preferred key and takes
precedence over
+ // the rest.authorization-url alias when both are set.
Review Comment:
This global alias precedence loses REST config layer precedence after
fetchConfig merges defaults, client props, and server overrides. If the client
supplied WithAuthURI(A), toProps now adds oauth2-server-uri=A, and a server
/config override of rest.authorization-url=B leaves both keys in the merged
map. This switch then chooses A, so the server override is ignored. Please
resolve the oauth2-server-uri/rest.authorization-url alias within each source
layer before merging, or otherwise preserve defaults → client → overrides
precedence, and add a regression test for WithAuthURI(A) plus a server
rest.authorization-url=B override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
