jayceslesar commented on PR #3602: URL: https://github.com/apache/iceberg-python/pull/3602#issuecomment-4888089550
Do we even need tests? I don't think it is our job to test that the `removeprefix` builtin works. Additionally, this abstraction over a builtin is only used in one place, would it be simpler to just use `removeprefix` in the only place that [`_remove_property_prefix`](https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/dynamodb.py#L840C13-L840C36) is used and just have a comment explaining why we are calling`removeprefix`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
