blackmwk commented on code in PR #2586:
URL: https://github.com/apache/iceberg-rust/pull/2586#discussion_r3527548721
##########
crates/iceberg/src/spec/manifest_list/manifest_file.rs:
##########
@@ -178,7 +179,14 @@ impl ManifestFile {
///
/// This method will also initialize inherited values of
[`ManifestEntry`](crate::spec::ManifestEntry), such as `sequence_number`.
pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
- let avro = file_io.new_input(&self.manifest_path)?.read().await?;
+ let input = file_io.new_input(&self.manifest_path)?;
+ let avro = match &self.key_metadata {
+ Some(key_metadata_bytes) => {
+ let key_metadata =
StandardKeyMetadata::decode(key_metadata_bytes)?;
Review Comment:
Maybe we need to have `ManifestFileLoader` as others?
##########
crates/iceberg/src/spec/manifest_list/manifest_file.rs:
##########
@@ -178,7 +179,14 @@ impl ManifestFile {
///
/// This method will also initialize inherited values of
[`ManifestEntry`](crate::spec::ManifestEntry), such as `sequence_number`.
pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
- let avro = file_io.new_input(&self.manifest_path)?.read().await?;
+ let input = file_io.new_input(&self.manifest_path)?;
+ let avro = match &self.key_metadata {
+ Some(key_metadata_bytes) => {
+ let key_metadata =
StandardKeyMetadata::decode(key_metadata_bytes)?;
Review Comment:
But it should not be included in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
