nastra commented on code in PR #15713:
URL: https://github.com/apache/iceberg/pull/15713#discussion_r3527528140
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -455,36 +456,40 @@ private boolean manifestHasDeletedFiles(
boolean isDelete = reader.isDeleteManifestReader();
- for (ManifestEntry<F> entry : reader.liveEntries()) {
Review Comment:
the reader is being opened/closed one level further above in
https://github.com/apache/iceberg/blob/c31dd921e1550c643a3ea1fce9d9573cc06e2607/core/src/main/java/org/apache/iceberg/ManifestFilterManager.java#L380
and then reused across these two methods. Why is it now better to open/close
the reader twice instead of once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
