pvary commented on code in PR #17024:
URL: https://github.com/apache/iceberg/pull/17024#discussion_r3529253081
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/EvolveSchemaVisitor.java:
##########
@@ -211,8 +212,15 @@ private void updateColumn(Types.NestedField existingField,
Types.NestedField tar
String existingColumnName =
this.existingSchema.findColumnName(existingField.fieldId());
boolean needsOptionalUpdate = targetField.isOptional() &&
existingField.isRequired();
+ boolean narrowingHandledByConversion =
+ existingField.type().isPrimitiveType()
+ && targetField.type().isPrimitiveType()
+ && TypeUtil.isPromotionAllowed(
Review Comment:
IIRC the Date -> timestamp_without_zone promotion is added later to the
spec, but the implementation might not be there yet.
We might want to fix the functionality around the full Iceberg
implementation, or remove the functionality from the DynamicSink too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
