wombatu-kun commented on code in PR #16620:
URL: https://github.com/apache/iceberg/pull/16620#discussion_r3529545395
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -206,15 +206,17 @@ static void cleanupMetadataAndUnlock(
default Table newHmsTable(String hmsTableOwner) {
Preconditions.checkNotNull(hmsTableOwner, "'hmsOwner' parameter can't be
null");
- final long currentTimeMillis = System.currentTimeMillis();
+ // createTime and lastAccessTime are HMS Thrift i32 fields (epoch
seconds), so the value must be
+ // narrowed to int here; the width is dictated by the metastore protocol
and cannot be widened.
Review Comment:
Done a6d5040 - trimmed to the single-line comment in both the table and view
creation paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
