nastra commented on code in PR #16363:
URL: https://github.com/apache/iceberg/pull/16363#discussion_r3529795602
##########
docs/docs/configuration.md:
##########
@@ -57,8 +56,8 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.parquet.bloom-filter-max-bytes | 1048576 (1 MB)
| The maximum number of bytes for a bloom filter bitset
|
| write.parquet.bloom-filter-fpp.column.col1 | 0.01
| The false positive probability for a bloom filter applied to 'col1'
(must > 0.0 and < 1.0)
|
| write.parquet.bloom-filter-ndv.column.col1 | (not set)
| The expected number of distinct values for a bloom filter applied to
'col1' (must > 0)
|
+| write.parquet.bloom-filter-adaptive-enabled | false
| Use parquet-mr adaptive bloom filter sizing (PARQUET-2254): evaluate
candidate filters and pick the smallest that satisfies the actual NDV at the
configured FPP, bounded by 'bloom-filter-max-bytes', instead of always
allocating the full max-bytes buffer |
Review Comment:
```suggestion
| write.parquet.bloom-filter-adaptive-enabled | false
| Use Parquet adaptive bloom filter sizing, which evaluate candidate
filters and picks the smallest that satisfies the actual NDV at the configured
FPP, bounded by 'write.parquet.bloom-filter-max-bytes', instead of always
allocating the full max-bytes buffer |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
