badalprasadsingh commented on PR #1244: URL: https://github.com/apache/iceberg-go/pull/1244#issuecomment-4895982225
Hey @laskoviymishka & @zeroshade, thank you again for the re-review! I've addressed all of the comments mentioned above. Please let me know if there's anything else that needs to be changed. Just a quick heads up: [Iceberg-Java](https://github.com/apache/iceberg/blob/04a35e412d2f37bb03e0cc68d56111be5d8dbb5b/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L250), makes this check case-insensitive, so I've updated the Go implementation to match that behavior for parity. Happy to change it if we're thinking differently. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
