rambleraptor commented on code in PR #3584:
URL: https://github.com/apache/iceberg-python/pull/3584#discussion_r3531237425
##########
pyiceberg/table/__init__.py:
##########
@@ -2471,8 +2471,9 @@ def plan_files(self) -> Iterable[FileScanTask]:
options=self.options,
).plan_files(
manifests=manifests,
- manifest_entry_filter=lambda manifest_entry:
manifest_entry.snapshot_id in append_snapshot_ids
Review Comment:
This looks stray. Can you remove this?
##########
pyiceberg/types.py:
##########
@@ -324,6 +324,8 @@ class DecimalType(PrimitiveType):
root: tuple[int, int]
def __init__(self, precision: int, scale: int) -> None:
+ if not (1 <= precision <= 38):
+ raise ValidationError(f"Precision must be between 1 and 38
(inclusive), got: {precision}")
Review Comment:
+1. This is how we do validations elsewhere in the code as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
