rambleraptor commented on code in PR #1283:
URL: https://github.com/apache/iceberg-go/pull/1283#discussion_r3531639133
##########
table/snapshot_producers.go:
##########
@@ -60,6 +60,15 @@ type producerImpl interface {
// unconditionally a no-op; commit() skips validator registration
// entirely when this returns false, so validate will never run.
needsValidation() bool
+ // rebuildFromInheritedOnly reports whether OCC retries should re-derive
+ // this producer's manifests from the fresh parent rather than carrying
+ // forward the manifests built on the first attempt. A rewrite
re-expresses
+ // inherited manifests, so it rebuilds; appends carry forward. Default
false.
+ rebuildFromInheritedOnly() bool
Review Comment:
Sounds great. @zeroshade had a similar suggestion. Made that change and
removed the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
