CTTY commented on code in PR #16794:
URL: https://github.com/apache/iceberg/pull/16794#discussion_r3532445443
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -292,12 +302,15 @@ public AwsProperties(Map<String, String> properties) {
properties, CLIENT_ASSUME_ROLE_TIMEOUT_SEC,
CLIENT_ASSUME_ROLE_TIMEOUT_SEC_DEFAULT);
this.clientAssumeRoleExternalId =
properties.get(CLIENT_ASSUME_ROLE_EXTERNAL_ID);
this.clientAssumeRoleRegion = properties.get(CLIENT_ASSUME_ROLE_REGION);
- this.clientAssumeRoleSessionName =
properties.get(CLIENT_ASSUME_ROLE_SESSION_NAME);
+ this.clientAssumeRoleSessionName =
+ properties.getOrDefault(
+ CLIENT_ASSUME_ROLE_SESSION_NAME, String.format("iceberg-aws-%s",
UUID.randomUUID()));
Review Comment:
I think we should still initialize this lazily. Auto-gen this is actually a
behavior change.
We can check and generate this in `createAssumeRoleRequest`
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -493,10 +506,51 @@ private AwsCredentialsProvider credentialsProvider(
return credentialsProvider(this.clientCredentialsProvider);
}
+ // When a role is configured to be assumed (e.g. via
AssumeRoleAwsClientFactory), sign requests
+ // with the assumed-role credentials so that they do not diverge from the
credentials used for
+ // S3, Glue, KMS and DynamoDB. See
https://github.com/apache/iceberg/issues/16667.
+ if (!Strings.isNullOrEmpty(this.clientAssumeRoleArn)) {
+ if (!Strings.isNullOrEmpty(this.clientAssumeRoleRegion)) {
+ return assumeRoleCredentialsProvider();
+ }
+
+ LOG.warn(
+ "Cannot assume role {} to sign REST requests because {} is not set; "
+ + "falling back to the default credentials provider.",
+ this.clientAssumeRoleArn,
+ CLIENT_ASSUME_ROLE_REGION);
+ }
+
// Create a new credential provider for each client
return DefaultCredentialsProvider.builder().build();
}
+ protected StsAssumeRoleCredentialsProvider assumeRoleCredentialsProvider() {
Review Comment:
This should be package private/no accessibility modifier?
```
StsAssumeRoleCredentialsProvider assumeRoleCredentialsProvider() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
