CTTY commented on code in PR #2596:
URL: https://github.com/apache/iceberg-rust/pull/2596#discussion_r3532678501
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -338,7 +338,10 @@ impl<'a> SnapshotProducer<'a> {
writer.write_manifest_file().await
}
- async fn manifest_file<OP: SnapshotProduceOperation, MP: ManifestProcess>(
+ /// Collects the list of manifest files to be included in the new snapshot.
+ ///
+ /// This method also writes the new manifests where required.
+ async fn produce_manifest_file_list<OP: SnapshotProduceOperation, MP:
ManifestProcess>(
Review Comment:
I'm thinking `produce_manifest_files` would better distinguish this from
manifest list, which is a separate concept
Or `produce_manifests`, which is closer to java's terms. I'm happy with both!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
