nssalian commented on code in PR #16957:
URL: https://github.com/apache/iceberg/pull/16957#discussion_r3533399791
##########
core/src/test/java/org/apache/iceberg/DataTableScanTestBase.java:
##########
@@ -310,4 +311,64 @@ public void testManifestLocationsInScanWithDeleteFiles()
throws IOException {
.get(0);
assertThat(deletes.get(0).manifestLocation()).isEqualTo(deleteManifest.path());
}
+
+ @TestTemplate
Review Comment:
Looking closely, both these tests use the same spec (id 0) for the delete
and the data file, so they exercise the "Mismatched partition tuples" branch
but not the "Mismatched partition specs" branch in `validatePartitionMatch`.
Worth a small follow-up test that evolves the spec and asserts the spec-id
mismatch message, so both checks are covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
