Copilot commented on code in PR #17120:
URL: https://github.com/apache/iceberg/pull/17120#discussion_r3533541514
##########
format/expressions-spec.md:
##########
@@ -281,21 +281,24 @@ If a function reference is a list of strings, it is the
function identifier and
### Predicates
```
-PREDICATE: true | false
+PREDICATE: { "type": BOOLEAN_CONST }
| { "type": "not", "child": PREDICATE }
| { "type": BINARY_OP, "left": PREDICATE, "right": PREDICATE }
| { "type": UNARY_OP, "child": EXPR }
| { "type": CMP_OP, "left": EXPR, "right": EXPR }
| { "type": SET_OP, "child": EXPR, "values": LITERALS }
| DEPRECATED_PREDICATE
+BOOLEAN_CONST: "true" | "false"
BINARY_OP: "and" | "or"
UNARY_OP: "is-null" | "not-null" | "is-nan" | "not-nan"
CMP_OP: "lt" | "lt-eq" | "gt" | "gt-eq" | "eq" | "not-eq"
| "starts-with" | "not-starts-with"
SET_OP: "in" | "not-in"
```
+Boolean predicate constants are serialized as objects to avoid ambiguity with
boolean literal values.
+
### Backward compatibility
Review Comment:
The spec previously allowed predicate constants to be serialized as bare
JSON booleans (`true` / `false`), but the updated "Backward compatibility"
section doesn’t mention that change. Adding a short note here would help
implementers who may need to read earlier drafts and makes it explicit whether
bare booleans are still accepted or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
