manuzhang commented on code in PR #822:
URL: https://github.com/apache/iceberg-cpp/pull/822#discussion_r3533733142
##########
src/iceberg/data/file_scan_task_reader.cc:
##########
@@ -161,9 +165,9 @@ class FileScanTaskReader::Impl {
data_file->file_size_in_bytes);
if (task.delete_files().empty()) {
- auto options =
- MakeReaderOptions(*data_file, io_, projected_schema_,
task.residual_filter(),
- name_mapping_, properties_);
+ auto options = MakeReaderOptions(
Review Comment:
REST scan-task JSON appears to round-trip only `first-row-id` for
`DataFile`; `FileScanTasksFromJson` constructs the `FileScanTask` without any
data sequence number. That means this call can pass `data_file->first_row_id`
but an empty `data_file->data_sequence_number`, and
`MakeLastUpdatedSequenceNumberArray` will return nulls for
`_last_updated_sequence_number`.
The row-lineage spec says missing/null `_last_updated_sequence_number`
should be replaced with the data file’s data sequence number.
(Disclaimer: The comment is generated by AI and reviewed by myself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
