HeartSaVioR commented on a change in pull request #1972:
URL: https://github.com/apache/iceberg/pull/1972#discussion_r547702165



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -58,9 +58,11 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, 
SupportsNamespaces {
+public class HiveCatalog extends BaseMetastoreCatalog implements 
AutoCloseable, SupportsNamespaces {

Review comment:
       I'm not sure this diff "technically" change anything. Sounds unnecessary 
unless explained.

##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -58,9 +58,11 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, 
SupportsNamespaces {
+public class HiveCatalog extends BaseMetastoreCatalog implements 
AutoCloseable, SupportsNamespaces {

Review comment:
       I'm not sure this diff "technically" changes anything. Sounds 
unnecessary unless explained.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to