emkornfield commented on code in PR #2783:
URL: https://github.com/apache/iceberg-rust/pull/2783#discussion_r3539740101
##########
crates/iceberg/src/spec/values/datum.rs:
##########
@@ -1086,6 +1086,16 @@ impl Datum {
}
}
+ fn f64_to_f32(val: f64) -> Datum {
+ if val > f32::MAX as f64 {
+ Datum::new(PrimitiveType::Float, PrimitiveLiteral::AboveMax)
+ } else if val < -(f32::MAX as f64) {
Review Comment:
```suggestion
} else if val < (f32::MIN as f64) {
```
Would this be more idiomatic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
