stevenzwu commented on code in PR #17133:
URL: https://github.com/apache/iceberg/pull/17133#discussion_r3539962055
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -75,7 +68,7 @@ public PartitionData copy() {
private Tracking tracking = null;
private long recordCount = -1L;
private long fileSizeInBytes = -1L;
- private PartitionData partitionData = EMPTY_PARTITION_DATA;
+ private PartitionData partitionData = null;
Review Comment:
Breaks `TestTrackedFileAdapters.testUnpartitionedFilePartitionIsEmpty` —
`DataFile.partition()` needs to stay non-null for unpartitioned files. #17000
does the boundary translation (adds `PartitionData.EMPTY`, returns it from the
adapter when the internal partition is null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
