ebyhr commented on code in PR #3614:
URL: https://github.com/apache/iceberg-python/pull/3614#discussion_r3540569712
##########
tests/utils/test_datetime.py:
##########
Review Comment:
We could add another test verifying an invalid precision without offset as a
follow-up. e.g. `2025-02-23T16:21:44.0123456789`
##########
tests/utils/test_datetime.py:
##########
@@ -111,6 +111,8 @@ def test_datetime_to_nanos(datetime_: datetime, nanos: int)
-> None:
[
("1970-01-01T00:00:00", 0),
("2025-02-23T20:21:44.375612", 1740342104375612000),
+ ("2025-02-23T20:21:44.3756127", 1740342104375612700),
+ ("2025-02-23T20:21:44.37561278", 1740342104375612780),
Review Comment:
We could modify the value to something like `2025-02-23T20:21:44.12345678`
to easily understand the precision.
Additionally, we should cover all precisions (1~5 look missing). However,
follow-up is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
