moomindani commented on PR #3551: URL: https://github.com/apache/iceberg-python/pull/3551#issuecomment-4912941793
The v3 spec marks `next-row-id` as required in table metadata. With this change, `new_table_metadata` constructs `TableMetadataV3` with `next_row_id=None`, and since `model_dump_json` uses `exclude_none`, newly created v3 tables are written without `next-row-id`. Would it make sense to initialize it to 0 as part of this PR? (Upgrades to v3 are tracked separately in #3622, and the remaining write-side pieces in #3620 / #3621.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
