openinx opened a new pull request #1978:
URL: https://github.com/apache/iceberg/pull/1978


   To verify that flink sql could write cdc/upsert events to iceberg table 
correctly,  I made few changes to let it work: 
   
   1.  Mapping the flink `CREATE TABLE` DDL's primary key to iceberg's equality 
field columns, that means when creating a flink table with primary key,  it 
will create an iceberg table with the `equality.field.columns` properties 
indicating which columns are  equality columns.   Apache Flink does not support 
altering primary key in DDL,  so we don't support alter equality field columns 
in SQL, will need to use the iceberg java API to accomplish schema evolution. 
   
   2.  I exposed the iceberg format v2 to end users in this patch because I 
found that the iceberg catalog has no way to share the `TableTestBase`.   It's 
not the correct time to expose format v2, so I will try to find another way to 
make the unit tests work. 
   
   3. Provide a basic unit test to verify the sql job work,  it will need more 
work to add more unit tests,  still in-progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to