twuebi opened a new pull request, #1428: URL: https://github.com/apache/iceberg-go/pull/1428
…lidation validateNoNewDeletesForRewrittenFiles only flagged concurrent position deletes whose referenced_data_file column (field 143) was set, a column V2 writers commonly leave empty, so a partition-scoped pos-delete committed during a rewrite passed validation and its deletes were silently lost. Mirror Java's ContentFileUtil.referencedDataFile and DeleteFileIndex: resolve a pos-delete's target via referenced_data_file, then via equal file_path lower/upper bounds, and otherwise match it against the rewritten files by (spec ID, partition tuple). Partition tuples are compared through an injective, type-normalized key that unifies the known Avro-decode and write-side value representations and fails the commit on unknown value types rather than guessing. Covered by unit tests over every resolution path and end-to-end tests on unpartitioned, int-partitioned, and date-partitioned tables where both sides round-trip real Avro manifests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
