ferenc-csaky commented on code in PR #17142:
URL: https://github.com/apache/iceberg/pull/17142#discussion_r3551950205
##########
docs/docs/flink-maintenance.md:
##########
@@ -397,6 +411,10 @@
flinkConf.put("flink-maintenance.expire-snapshots.max-snapshot-age-seconds", "60
// Configure delete orphan files
flinkConf.put("flink-maintenance.delete-orphan-files.min-age-seconds",
"259200");
+// Configure convert equality deletes. Converts in place on the write branch
by default;
+// set a target branch to instead promote the converted deletion vectors there.
Review Comment:
nit: weird sentence, some possible rewording:
```
// set a target branch to promote the converted deletion vectors there
instead.
```
##########
docs/docs/flink-maintenance.md:
##########
@@ -397,6 +411,10 @@
flinkConf.put("flink-maintenance.expire-snapshots.max-snapshot-age-seconds", "60
// Configure delete orphan files
flinkConf.put("flink-maintenance.delete-orphan-files.min-age-seconds",
"259200");
+// Configure convert equality deletes. Converts in place on the write branch
by default;
+// set a target branch to instead promote the converted deletion vectors there.
Review Comment:
nit: weird sentence, possible rewording:
```
// set a target branch to promote the converted deletion vectors there
instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
