ajantha-bhat commented on code in PR #16947:
URL: https://github.com/apache/iceberg/pull/16947#discussion_r3551966330
##########
.github/workflows/flink-ci.yml:
##########
@@ -103,7 +116,9 @@ jobs:
# Read-only: java-ci's build-checks (17) is the global canonical
writer.
cache-read-only: true
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- - run: ./gradlew -DsparkVersions= -DkafkaVersions= -DflinkVersions=${{
matrix.flink }} :iceberg-flink:iceberg-flink-${{ matrix.flink }}:check
:iceberg-flink:iceberg-flink-runtime-${{ matrix.flink }}:check -Pquick=true -x
javadoc -DtestParallelism=auto
+ - env:
+ FLINK_VERSION: ${{ matrix.flink }}
Review Comment:
Storing as env variable now. Because if I directly use matrix values like
{{matrix.flink}} it is unsafe pattern now. Since matrix values are now fetched
from planner script.
Error from zizmor
may expand into attacker-controllable code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
