zeroshade commented on code in PR #1402:
URL: https://github.com/apache/iceberg-go/pull/1402#discussion_r3553539658
##########
manifest.go:
##########
@@ -144,13 +144,44 @@ func (b *ManifestBuilder) DeletedRows(cnt int64)
*ManifestBuilder {
}
func (b *ManifestBuilder) Partitions(p []FieldSummary) *ManifestBuilder {
- b.m.PartitionList = &p
+ if p == nil {
+ b.m.PartitionList = nil
+
Review Comment:
nit: worth a one-line comment noting the intentional behavior change —
previously `Partitions(nil)` stored a non-nil pointer to a nil slice (`&p`),
whereas now it stores `nil` (same for `KeyMetadata(nil)`). It's arguably more
correct, but Avro serialization sees a nil-pointer vs. empty-value difference,
so a note would help future readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
