steveis commented on PR #2785: URL: https://github.com/apache/iceberg-rust/pull/2785#issuecomment-4927893931
Pushed 6ed0879 addressing review feedback from Andrei Tserakhau (iceberg-go implementer of the same feature — feedback received by email): - **Content-based operation selection** matching Java's `BaseRowDelta`: data-only = `append`, deletes-only = `delete`, both = `overwrite` (was: always `overwrite`). - **Write-time equality-key guards**: reject empty `equality_ids` sets, unknown field ids, and float/double equality columns (equality undefined under NaN/signed zero). - **Conflict validation is now explicitly documented as deferred** (BaseRowDelta's `validateFromSnapshot`/`conflictDetectionFilter` surface); sequence-number semantics carry row-level correctness meanwhile. Already covered, for other reviewers' reference: the sequence-number rule lives in the reader (`delete_file_index.rs`: equality strictly-greater, position >=), and the round-trip test exercises the sharp edge directly — one RowDelta that equality-deletes a PK and re-inserts it in the same commit, read back through the scan path with equality deletes applied (not just position deletes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
