andybradshaw commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3554954586
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -2442,12 +2442,13 @@ mod tests {
"v2"
);
- // metadata version should be bumped
+ // metadata version should be bumped and the new metadata file is
written under the updated
+ // table location's metadata directory
assert!(
updated_table
.metadata_location()
.unwrap()
- .starts_with("s3://bucket/test/location/metadata/00001-")
+
.starts_with("s3://bucket/test/new_location/data/metadata/00001-")
Review Comment:
Yeah, I think in general splitting this into a fix and a feature would
probably be best. The implications of the behavior changes in respecting this
property vs. how updates on existing tables are handled might be different, and
I'd imagine the maintainers would appreciate being able to talk about them
independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
