ebyhr commented on code in PR #3635:
URL: https://github.com/apache/iceberg-python/pull/3635#discussion_r3558526160
##########
tests/test_transforms.py:
##########
@@ -1682,6 +1682,13 @@ def test_bucket_pyarrow_void_transform() -> None:
assert output_arr ==
VoidTransform().pyarrow_transform(IntegerType())(input_arr)
+def test_bucket_pyarrow_transform_dictionary_encoded() -> None:
Review Comment:
These new tests fail if we revert changes in transforms.py:
```
def _transform(array: "ArrayLike") -> "ArrayLike":
def _cast_if_needed(arr: "ArrayLike") -> "ArrayLike":
if expected_type is not None:
return arr.cast(expected_type)
else:
return arr
if isinstance(array, pa.Array):
> return _cast_if_needed(transform_func(array, *args))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E ValueError: FeatureUnsupported => Unsupported data type for
bucket transform: Dictionary(Int32, Utf8)
pyiceberg/transforms.py:149: ValueError
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
