laskoviymishka opened a new pull request, #1435: URL: https://github.com/apache/iceberg-go/pull/1435
MetadataBuilder.clone copies its fields by hand, so a field added to the struct but not to clone() is silently shared between builders. Add a reflection-based test that fills every field and asserts the clone is value-equal yet independently backed, catching both a dropped field and one copied by reference. Also cover the requirements half of apply's atomicity (a mid-batch update failure must not leak staged requirements), which no existing test exercised, and rename the generic pointer-clone helper from cloneMetadataBuilderInt to clonePtr since it is not int-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
