kevinjqliu commented on code in PR #16794:
URL: https://github.com/apache/iceberg/pull/16794#discussion_r3560695501
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -493,10 +510,55 @@ private AwsCredentialsProvider credentialsProvider(
return credentialsProvider(this.clientCredentialsProvider);
}
+ // When a role is configured to be assumed (e.g. via
AssumeRoleAwsClientFactory), sign requests
+ // with the assumed-role credentials so that they do not diverge from the
credentials used for
+ // S3, Glue, KMS and DynamoDB. See
https://github.com/apache/iceberg/issues/16667.
+ if (!Strings.isNullOrEmpty(this.clientAssumeRoleArn)) {
+ if (!Strings.isNullOrEmpty(this.clientAssumeRoleRegion)) {
+ return assumeRoleCredentialsProvider();
+ }
+
+ LOG.warn(
+ "Cannot assume role {} to sign REST requests because {} is not set; "
+ + "falling back to the default credentials provider.",
+ this.clientAssumeRoleArn,
+ CLIENT_ASSUME_ROLE_REGION);
+ }
+
// Create a new credential provider for each client
return DefaultCredentialsProvider.builder().build();
}
+ StsAssumeRoleCredentialsProvider assumeRoleCredentialsProvider() {
+ Preconditions.checkNotNull(
+ this.clientAssumeRoleRegion,
+ "Cannot create StsAssumeRoleCredentialsProvider with null region");
+ return StsAssumeRoleCredentialsProvider.builder()
+ .stsClient(
+ StsClient.builder()
+
.applyMutation(httpClientProperties::applyHttpClientConfigurations)
+ .region(Region.of(this.clientAssumeRoleRegion))
Review Comment:
Codex flagged this:
AwsProperties.java now sets the STS client region from
client.assume-role.region, but the existing contract says that property applies
to AWS clients except STS.
```
| `client.assume-role.region` | null, requires user input
| All AWS clients except the STS client will use the given region instead
of the default region chain |
```
We might want to update one of the places to match behavior (cc @CTTY)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
