sungwy commented on code in PR #17137:
URL: https://github.com/apache/iceberg/pull/17137#discussion_r3561289896
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3120,6 +3120,13 @@ components:
AddSchemaUpdate:
allOf:
- $ref: '#/components/schemas/BaseUpdate'
+ description:
+ Adds a schema to the table. The field IDs in `schema` are assigned by
the client. The client
+ assigns them so that the schema stays consistent with the data files,
partition specs, and
+ sort orders it writes or co-commits, which reference fields by their
field ID
+ (`StructField.id`). Servers SHOULD preserve the field IDs submitted by
the client on
Review Comment:
Thanks @rambleraptor and @rdblue
> I prefer "must" (or MUST if you must).
This was my opinion, but @wombatu-kun made a [sharp
observation](https://github.com/apache/iceberg/pull/17137#discussion_r3556011641)
that `AddSchemaUpdate` is also shared with the `View` commit path, and that
the invariant is vacuous for Views.
Given that, I'm finding it hard to promote this normative clause to a `MUST`
uniformly, so I'm inclined to keep it as a `SHOULD` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
