zeroshade commented on code in PR #1283:
URL: https://github.com/apache/iceberg-go/pull/1283#discussion_r3561574928
##########
table/snapshot_producers.go:
##########
@@ -444,12 +454,32 @@ func (m *manifestMergeManager) mergeGroup(firstManifest
iceberg.ManifestFile, sp
}
if err := g.Wait(); err != nil {
+ // Delete bins that finished before this one failed.
+ m.removeOrphans(manifests, slices.Concat(binResults...))
Review Comment:
Minor / non-blocking, and pre-existing — flagging for a possible follow-up
rather than this PR.
This correctly cleans up bins that finished before a sibling failed. The one
case it can't reach is a bin that fails *inside* `createManifest` after
`newManifestWriter` has already opened its output file: that path never makes
it into `binResults`, so its partial `.avro` is left behind. Since
`createManifest` is shared with `mergeAppendFiles` and predates this change,
I'd treat it as a separate follow-up, not a blocker here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
