fallintoplace opened a new pull request, #1441: URL: https://github.com/apache/iceberg-go/pull/1441
NamespaceFromIdent sliced with an upper bound of -1 for an empty identifier, allowing invalid public API input to panic. The shared staging helper also derived the namespace before validating the table identifier. NamespaceFromIdent now returns nil for empty input, and table creation validates before resolving locations or writing metadata. SQL table operations validate at their public boundaries, while Glue and Hive table identifier conversion now uses the shared typed validator. Existing error conventions are preserved: missing namespaces during creation return `ErrNoSuchNamespace`; lookup and mutation operations return `ErrNoSuchTable`. Regression coverage passes nil, empty, and one-component identifiers through create, load, commit, drop, purge, rename, and existence checks for SQL, Glue, and Hive. Backend mocks receive no calls for rejected identifiers. Tests: - `go test ./...` - `golangci-lint run --timeout=10m` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
