wgtmac commented on code in PR #820:
URL: https://github.com/apache/iceberg-cpp/pull/820#discussion_r3563966532
##########
.clang-tidy:
##########
@@ -41,5 +42,7 @@ CheckOptions:
value: '_'
- key: modernize-use-scoped-lock.WarnOnSingleLocks
value: 'false'
+ - key: misc-include-cleaner.IgnoreHeaders
+ value: 'arrow/.*;nanoarrow/.*;nlohmann/.*;spdlog/.*;roaring/.*;cpr/.*'
Review Comment:
```suggestion
- key: misc-include-cleaner.IgnoreHeaders
value:
'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;sqlite3\.h;thrift/.*;utf8proc\.h;zlib\.h'
```
IgnoreHeaders should cover the other third-party headers currently included
from src/iceberg and tests too. In particular, utf8proc.h was added on main
after this PR branched, and existing dependencies like Avro/Parquet, sqlpp23,
zlib, sqlite3, gtest/gmock, and optional AWS/Thrift headers can otherwise
produce include-cleaner noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
