timothyw553 opened a new issue, #829: URL: https://github.com/apache/iceberg-cpp/issues/829
## Context GTest dependency setup currently lives in `src/iceberg/test/CMakeLists.txt`, and the new Google Benchmark setup in #825 follows the same local pattern in `src/iceberg/benchmark/CMakeLists.txt`. Review feedback on #825 suggested moving this dependency setup into `IcebergThirdpartyToolchain.cmake` instead. ## Proposal Move both GTest and Google Benchmark CMake dependency setup into `cmake_modules/IcebergThirdpartyToolchain.cmake`, so third-party dependency resolution is kept in one place. ## Notes This should be handled as a separate cleanup from #825, since #825 is only adding the benchmark build scaffolding and intentionally follows the existing GTest pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
