plusplusjiajia commented on code in PR #2660:
URL: https://github.com/apache/iceberg-rust/pull/2660#discussion_r3565646675


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -145,6 +159,12 @@ impl RestCatalogBuilder {
         self.config.client = Some(client);
         self
     }
+
+    /// Injects a custom request signer, overriding the `rest.sigv4-*` 
configuration.
+    pub fn with_signer(mut self, signer: Arc<dyn HttpRequestSigner>) -> Self {

Review Comment:
   Prototype is up as a draft PR: #2815 — full `AuthManager`/`AuthSession` 
shape with `Noop`/`OAuth2`/`SigV4` managers; details and known simplifications 
in the PR description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to