huan233usc commented on code in PR #17149:
URL: https://github.com/apache/iceberg/pull/17149#discussion_r3566679002
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -169,7 +170,18 @@ private boolean supportsParquetBatchReads(ScanTask task) {
}
private boolean supportsParquetBatchReads(Types.NestedField field) {
- return field.type().isPrimitiveType() ||
MetadataColumns.isMetadataColumn(field.fieldId());
+ if (MetadataColumns.isMetadataColumn(field.fieldId())) {
+ return true;
+ }
+
+ Type type = field.type();
+ // Geometry and geography are primitive types but have no Arrow vector
yet, so they must be
+ // read through the non-vectorized reader.
+ if (type.typeId() == Type.TypeID.GEOMETRY || type.typeId() ==
Type.TypeID.GEOGRAPHY) {
Review Comment:
Done in 3698f8c73 — updated the comment above `useParquetBatchReads()` to
note geometry and geography are primitives that are intentionally excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
