pvary commented on PR #16110: URL: https://github.com/apache/iceberg/pull/16110#issuecomment-4956006317
> One thing worth flagging on the "TableScan-based test" ask: the modern reader path (ReadConf/ParquetReader, used whenever a createReaderFunc/batched func is set) does its row-group filtering with ParquetMetricsRowGroupFilter et al. against the expected/table schema and never calls ParquetFilters.convert(). convert() is only reached via the legacy read-support (ParquetReadBuilder) path, which binds the filter against the physical file schema — that's the only place the missing-column case arises. So a TableScan going through createReaderFunc won't exercise this code at all. I just found out this in another PR. This means, that the `ParquetFilters.convert()` is only used in deprecated code paths and it will be removed in 2.0. Based on this, if you don't have other info, it might not worth to put more effort to fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
