rdblue commented on code in PR #17133:
URL: https://github.com/apache/iceberg/pull/17133#discussion_r3573801470
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -240,12 +231,9 @@ void copy() {
assertThat(copy.keyMetadata()).isEqualTo(ByteBuffer.wrap(new byte[] {1, 2,
3}));
assertThat(copy.splitOffsets()).containsExactly(100L, 200L);
assertThat(copy.equalityIds()).containsExactly(1, 2, 3);
-
- assertThat(PARTITION_COMPARATOR.compare(copy.partition(),
PARTITION)).isEqualTo(0);
+ assertThat(copy.partition()).isSameAs(PARTITION_COPY);
// mutable fields are deep-copied, not shared with the original
- assertThat(copy.tracking()).isNotSameAs(file.tracking());
Review Comment:
My rationale is that `isSameAs(x)` implies `isNotSameAs(y)` if `x` is not
the same as `y` because the relation is transitive. By verifying `isSameAs`,
this is already ensuring it is the result of `copy`.
We could go further and use this as a validation that `copy` produces a
different object (it does not always) but that is the responsibility of the
tests for `TrackingStruct`, not `TrackedFileStruct`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
