gerashegalov commented on code in PR #16154:
URL: https://github.com/apache/iceberg/pull/16154#discussion_r3575599729
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -39,13 +39,16 @@
*
* <ol>
* <li>Read options
- * <li>Session configuration
+ * <li>Session configuration (e.g. {@code spark.sql.iceberg.read.split-size})
* <li>Table metadata
* </ol>
*
* The most specific value is set in read options and takes precedence over
all other configs. If no
- * read option is provided, this class checks the session configuration for
any overrides. If no
- * applicable value is found in the session configuration, this class uses the
table metadata.
+ * read option is provided, this class checks the session configuration. If no
applicable value is
+ * found in the session configuration, this class uses the table metadata.
+ *
+ * <p>For split size, session overrides are treated like explicit read options
and disable adaptive
Review Comment:
Good point @szehon-ho. I removed the split-size-specific Javadoc entirely to
keep this consistent with the other config accessors. The behavior is still
covered by the docs and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
