dannycjones commented on code in PR #2799: URL: https://github.com/apache/iceberg-rust/pull/2799#discussion_r3577919535
########## CONTRIBUTING.md: ########## @@ -121,3 +121,12 @@ dependency versions without always upgrading to the latest. ## Code of Conduct We expect all community members to follow our [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). + +## RFC Process Review Comment: Rather than describing this section as the RFC process, should we instead have it as a "Larger Changes" section? Or at least point to this section from earlier on. I see under _Merge Style_, we talk about larger changes being directed to the mailing list and Slack. It might be a good opportunity to help guide contributors. ########## CONTRIBUTING.md: ########## @@ -121,3 +121,12 @@ dependency versions without always upgrading to the latest. ## Code of Conduct We expect all community members to follow our [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). + +## RFC Process + +For significant changes, new features, or substantial changes to public APIs, consider opening an RFC PR first: Review Comment: Agree, this is a good opportunity to disambiguate on what should be an Iceberg spec change vs. what's only for iceberg-rust. ########## CONTRIBUTING.md: ########## @@ -121,3 +121,12 @@ dependency versions without always upgrading to the latest. ## Code of Conduct We expect all community members to follow our [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). + +## RFC Process Review Comment: I think it would be great to include those examples below (perhaps https://github.com/apache/iceberg-rust/pull/2183 too), especially as we want to direct spec changes to Iceberg's main repo and we can give these as good examples of language implementation RFCs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
