rdblue commented on a change in pull request #1996:
URL: https://github.com/apache/iceberg/pull/1996#discussion_r549462204
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -172,6 +174,20 @@ public Builder writeParallelism(int newWriteParallelism) {
return this;
}
+ /**
+ * All INSERT/UPDATE_AFTER events from input stream will be transformed to
UPSERT events, which means it will
+ * DELETE the old records and then INSERT the new records. In partitioned
table, the partition fields should be
+ * a subset of equality fields, otherwise the old row that located in
partition-A could not be deleted by the
+ * new row that located in partition-B.
Review comment:
Does anything validate this constraint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
