szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r3578636123


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2158,9 +2165,10 @@ components:
           enum:
             - vended-credentials
             - remote-signing
+            - kms-vended-credentials

Review Comment:
   No it doesn't subsume. A client may support storage vended credentials while 
not kms vended credentials. As per spec such clients will not be given any 
credentials for encrypted tables, but for unencrypted ones it's still a valid 
scenario.
   Also, in general - I'd rather avoid including extra meaning to an existing 
access delegation mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to