vishnuprakaz opened a new pull request, #3653:
URL: https://github.com/apache/iceberg-python/pull/3653
Closes #3652
# Rationale for this change
`_to_partition_representation` has no handler for `TimestampNanoType` /
`TimestamptzNanoType`, so a `datetime` partition value
passes through unchanged instead of being converted to nanoseconds since
epoch. The manifest writer expects an int there, so
identity-partitioned writes on `timestamp_ns` columns would fail once v3
writing lands (#1551).
This adds a handler for the two nano types, mirroring the existing
microsecond one with `datetime_to_nanos`.
Happy to rework this or fold it into the v3 write effort if that's
preferred.
## Are these changes tested?
Yes, added unit tests covering `datetime`, int passthrough and `None` for
both nano types, plus the same cases for the microsecond
types which weren't covered before.
## Are there any user-facing changes?
No. Writing v3 tables is still gated, this just makes partitioned v3
writes work correctly once it's enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
