tanmayrauth commented on code in PR #1430:
URL: https://github.com/apache/iceberg-go/pull/1430#discussion_r3581382684
##########
table/table.go:
##########
@@ -603,7 +628,7 @@ func (t Table) doCommit(ctx context.Context, updates
[]Update, reqs []Requiremen
deleteOldMetadata(fs, t.metadata, newMeta)
- return New(t.identifier, newMeta, newLoc, t.fsF, t.cat), nil
+ return New(t.identifier, newMeta, newLoc, t.fsF, t.cat,
WithMetricsReporter(t.MetricsReporter())), nil
Review Comment:
Done. I went with the withReporterState(t.reporter, t.reporterSet) option
exactly as you suggested — copies both fields so it doesn't round-trip through
the never-nil accessor — and applied the same at StagedTable.
TestCommitPreservesDefaultedReporterInheritance locks down
create+Commit+Refresh; I verified it fails on the old line and passes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
