dossett commented on PR #3654: URL: https://github.com/apache/iceberg-python/pull/3654#issuecomment-4973709958
In the Iceberg slack @jayceslesar pointed out that #2695 addresses a related problem. One key objection in that PR was that the `ResidualEvaluator` should not be cached and reused because it is not thread safe. My original PR was doing that, but I changed it to never reuse the `ResidualEvaluator` but it still does cache the resulting residual-expression, which can be safely reused across files. In certain circumstances this is a significant benefit. (cc @jayceslesar @Fokko @kevinjqliu @ForeverAngry from that first PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
