rambleraptor commented on code in PR #1462:
URL: https://github.com/apache/iceberg-go/pull/1462#discussion_r3582614251
##########
table/table.go:
##########
@@ -866,9 +866,9 @@ func WithLimit(n int64) ScanOption {
}
}
-// WitMaxConcurrency sets the maximum concurrency for table scan and plan
+// WithScanMaxConcurrency sets the maximum concurrency for table scan and plan
// operations. When unset it defaults to runtime.GOMAXPROCS.
-func WitMaxConcurrency(n int) ScanOption {
+func WithScanMaxConcurrency(n int) ScanOption {
Review Comment:
Let's do the proper thing, especially with v1 looming.
- Rename this to WithMaxConcurrency
- Change orphan_cleanups to WithCleanupMaxConcurrency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
