manuzhang commented on code in PR #16946:
URL: https://github.com/apache/iceberg/pull/16946#discussion_r3584346520
##########
.github/workflows/spark-ci.yml:
##########
@@ -83,21 +99,12 @@ jobs:
matrix:
jvm: [17, 21]
event_name: ['${{ github.event_name }}']
- spark: ['3.5', '4.0', '4.1']
- scala: ['2.12', '2.13']
+ spark: ${{ fromJson(needs.plan.outputs.spark_versions) }}
+ scala: ${{ fromJson(needs.plan.outputs.scala_versions) }}
# Split iceberg-spark (core) from iceberg-spark-extensions/-runtime
# so they run as concurrent jobs rather than serially in one job.
tests: [core, extensions]
- exclude:
- # Spark 3.5 is the first version not failing on Java 21
(https://issues.apache.org/jira/browse/SPARK-42369)
- # Full Java 21 support is coming in Spark 4
(https://issues.apache.org/jira/browse/SPARK-43831)
- - spark: '4.0'
- scala: '2.12'
- - spark: '4.1'
- scala: '2.12'
- # Pull requests run the baseline JDK only.
- - event_name: pull_request
- jvm: 21
+ exclude: ${{ fromJson(needs.plan.outputs.matrix_excludes) }}
Review Comment:
Do we still need this exclude since we generate spark/scala versions at
runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
