fallintoplace opened a new pull request, #1466: URL: https://github.com/apache/iceberg-go/pull/1466
## Summary - check namespace existence, catalog-object emptiness, and property deletion in one serializable write transaction - treat views and future object types as namespace contents instead of relying on the table-only `ListTables` result - keep view-only namespaces intact and return an object-neutral `ErrNamespaceNotEmpty` error ## Why On the V1 SQL schema, `ListTables` intentionally excludes views. `DropNamespace` used that filtered result to decide whether a namespace was empty, so a namespace containing only a view could report a successful drop while the view row—and therefore the namespace—still existed. The separate pre-checks also left the decision outside the delete transaction. ## Testing - `go test ./catalog/sql` - repository package suite excluding the locally hanging `io/gocloud` test binary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
