fallintoplace opened a new pull request, #1470: URL: https://github.com/apache/iceberg-go/pull/1470
## Summary - clone binary prefixes before incrementing truncated upper bounds - return an owned copy when truncation is unnecessary - verify repeated truncation is stable and never aliases or mutates the input ## Why `TruncateUpperBoundBinary` sliced directly into the caller's byte array and incremented that shared prefix. Statistics aggregation could therefore mutate its stored maximum while merely calculating an upper bound, making later calls and comparisons depend on call order. ## Testing - `go test ./table/internal -run TestTruncateUpperBoundBinary -count=20` - `go test ./table/internal ./table` - `go vet ./table/internal ./table` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
